-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: laying the grounds for 10.0.0 #11517
Conversation
Co-authored-by: Antonio T. as Tony <Tony133@users.noreply.github.com>
ExternalExceptionHandler
The redis microservice now makes use of `psubscribe` and `pmessage` when the `wildcards` option is enabled in the options of the microservice, which makes it possible to use wildcards as specified by the Redis documentation. Closes #10344
The search method is going to be anexed with the @Search decorator and going to be used to reference a SEARCH request
This decorator uses the SEARCH method to construct a decorator for a handler to a Search http request
This update was really simple, because we dont need any kind of aliasing due to fastify and express already supporting the search method for Application
when transforming booleans with non-valid boolean values
on `ValidationPipe`, it must not return a valid boolean
and file-validator.interface and max-file-size.validator
Pull Request Test Coverage Report for Build 7956b6f3-024e-43f8-a40d-3862b14b8225
💛 - Coveralls |
Hello! Based on a Discord discussion, I'm proposing a change in That's the recommended mapping targeting Node16+ based on the typescripts docs. This change could be split to two steps:
I'm not experienced with what the target should be for libraries or the effect it has on users, so I can only leave this proposal here for better Ninjas to maybe consider. Also, here some references that helped me understand a bit more:
Thanks, and good luck with the release 🎉 |
@wodCZ If you take a look at changes in this PR, you'll notice that all samples & tsconfigs of libs in this repo were already updated to use When the core package is updated, other official packages in the ecosystem will follow (and use es2021 as well). I'll make sure to update starter projects & schematics too |
refactor(common): Add generic to InjectionToken type
Is there any estimated release date for v10 ? Especially waiting for #10953 |
@kamilmysliwiec lets pin this issue to get more input/ideas and also better visibility of the issue |
@XDoubleU there's no ETA I think it's a good time to update the main lock file as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thing the target should be ES2021 here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are many methods that are supported by both express and fastify but missing in the enum
https://expressjs.com/en/4x/api.html#routing-methods
https://www.fastify.io/docs/latest/Reference/Routes/#routes-options
…versioning fix(core): global prefix exclude when versioning is turned on
feat(core): middleware runs once for matching route
fix(fastify): validate middleware paths
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Node v12 will be no longer supported in v10.0.0 (>= v16 is required).
A few PRs that are spanning this release:
CUSTOM_ROUTE_AGRS_METADATA
#11450httpServer
#11115ValidationPipe
#10953getInstance
return type for http adapters #10630so there's gonna be several barely noticeable breaking changes (that won't affect the vast majority of users anyway).
Besides, there will be some changes to the tooling-related packages too (CLI, schematics), etc, we'll most likely drop support for older versions of TypeScript than v4.8 (since there're several AST-related breaking changes between x < v4.8 and also v4 and v5).
Creating this PR for better visibility & transparency.
Does this PR introduce a breaking change?
Other information